Skip to content

fix: try-catch deep read #10270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 23, 2024
Merged

fix: try-catch deep read #10270

merged 2 commits into from
Jan 23, 2024

Conversation

@dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Jan 23, 2024

Accessing values might throw errors if they're not just values but getters. Guard against that by try-catching every access so that $inspect doesn't fail fixes the iframe error in the playground reported in #10174

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@dummdidumm
fix: try-catch deep read
793b19a 
Accessing values might throw errors if they're not just values but getters. Guard against that by try-catching every access so that `$inspect` doesn't fail
fixes the iframe error in the playground reported in #10174
@dummdidumm
changeset
5d7ff44
@changeset-bot
Copy link

changeset-bot bot commented Jan 23, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 5d7ff44

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm dummdidumm merged commit 03c067f into main Jan 23, 2024
@dummdidumm dummdidumm deleted the try-catch-deep-read branch January 23, 2024 19:22
@dummdidumm dummdidumm mentioned this pull request Jan 23, 2024
Closed
@github-actions github-actions bot mentioned this pull request Jan 23, 2024
Merged
trueadm pushed a commit that referenced this pull request Jan 26, 2024
@dummdidumm @trueadm
fix: try-catch deep read (#10270)
afbd692 
Accessing values might throw errors if they're not just values but getters. Guard against that by try-catching every access so that `$inspect` doesn't fail
fixes the iframe error in the playground reported in #10174
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trueadm trueadm trueadm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dummdidumm @trueadm